Conversation
…ate yarn.lock for dependency management
joaquim-verges
approved these changes
Jan 30, 2025
|
This PR is stale because it has been open for 7 days with no activity. Remove stale label or comment or this PR will be closed in 3 days. |
|
We're building your pull request over on Zeet. |
|
This PR is stale because it has been open for 7 days with no activity. Remove stale label or comment or this PR will be closed in 3 days. |
0xFirekeeper
approved these changes
Feb 26, 2025
|
This PR is stale because it has been open for 7 days with no activity. Remove stale label or comment or this PR will be closed in 3 days. |
joaquim-verges
approved these changes
Mar 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR introduces error handling for invalid
BigIntvalues and integrates authorization handling into transaction schemas and processing. It enhances type safety and validation for transactions, particularly withauthorizationList.Detailed summary
badBigIntErrorfunction for error handling insrc/server/middleware/error.ts.InsertedTransactiontype to includeauthorizationListinsrc/shared/utils/transaction/types.ts.requiredBigIntfunction for validatingBigIntvalues insrc/shared/utils/primitive-types.ts.authorizationSchemaandauthorizationListSchemainsrc/server/schemas/transaction/authorization.ts.toParsedAuthorizationfunction for parsing authorization data.sendTransactionhandler to includeauthorizationListinsrc/server/routes/backend-wallet/send-transaction.ts.